Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure multifactor-authentication navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 #39

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

IlhemEssaadi
Copy link
Contributor

No description provided.

@azayati azayati changed the title feat: Add Multifactor authentication node to platform settings navigation - EXO-66546 - Meeds-io/MIPs#88 feat: Configure multifactor-authentication navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 Oct 12, 2023
@azayati azayati removed their request for review October 12, 2023 09:15
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see review

@@ -0,0 +1,22 @@
#
# Copyright (C) 2009 eXo Platform SAS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix header

Comment on lines 40 to 41
</page>

</page-set>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</page>
</page-set>
</page>
</page-set>

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati merged commit ad9cfd3 into feature/experience Oct 13, 2023
5 checks passed
@azayati azayati deleted the task/66546 branch October 13, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants