Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Title H3 has wrong text color - EXO-73171 - Meeds-io/MIPs#128 #44

Closed
wants to merge 1 commit into from
Closed

fix: Title H3 has wrong text color - EXO-73171 - Meeds-io/MIPs#128 #44

wants to merge 1 commit into from

Conversation

hakermi
Copy link
Member

@hakermi hakermi commented Jul 31, 2024

H3 has wrong text color

@hakermi hakermi changed the title fix: Title H3 has wrong text color - EXO-73171 - Meeds-io/MIPs#128 (#43) fix: Title H3 has wrong text color - EXO-73171 - Meeds-io/MIPs#128 Jul 31, 2024
@hakermi hakermi requested a review from ahamdi July 31, 2024 09:59
@hakermi hakermi enabled auto-merge (squash) July 31, 2024 09:59
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Jul 31, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rdenarie
rdenarie requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@rdenarie rdenarie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of this fix

As notes and news are both in meeds, why this commit is in commons-exo ?
The modification will not be in meeds package.

What we want to do exactly ?

@ahamdi ahamdi requested a review from rdenarie July 31, 2024 14:14
@rdenarie
Copy link
Member

as discussed with @Julien-Dubois-eXo and @hakermi this fix needs to be reworked

@hakermi hakermi closed this Jul 31, 2024
auto-merge was automatically disabled July 31, 2024 15:11

Pull request was closed

@hakermi hakermi deleted the dev-73171 branch July 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahamdi ahamdi Awaiting requested review from ahamdi

@rdenarie rdenarie Awaiting requested review from rdenarie

Assignees
No one assigned
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakermi @rdenarie