feat: Add note editor plugins extensions - EXO-73170 - Meeds-io/MIPs#128 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahamdi
reviewed
Jul 17, 2024
Comment on lines
35
to
58
| <load-group>NotesEditorGRP</load-group> | ||
| <script> | ||
| <minify>false</minify> | ||
| <path>/js/WYSIWYGPluginsExtensions.bundle.js</path> | ||
| </script> | ||
| <depends> | ||
| <module>vue</module> | ||
| </depends> | ||
| <depends> | ||
| <module>eXoVueI18n</module> | ||
| </depends> | ||
| <depends> | ||
| <module>vuetify</module> | ||
| </depends> | ||
| <depends> | ||
| <module>jquery</module> | ||
| <as>$</as> | ||
| </depends> | ||
| <depends> | ||
| <module>extensionRegistry</module> | ||
| </depends> | ||
| <depends> | ||
| <module>commonVueComponents</module> | ||
| </depends> |
There was a problem hiding this comment.
Does this extension need all those dependencies ?
|
ahamdi
approved these changes
Jul 18, 2024
sofyenne
added a commit
that referenced
this pull request
Jul 22, 2024
sofyenne
added a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, after removing the attachment app from the content module, the "select image" option was not available because the WYSIWYG plugins were registered in the attachment app. This change will add the Note Editor WYSIWYG Plugins Extension, which will be included using the load group in the content module, resolving this issue!