feat: Rename Dynamic container to include gtmpl only once in page - MEED-8323 - Meeds-io/MIPs#175 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EED-8323 - Meeds-io/MIPs#175 Due to changes made in Site Layout Editor MIP, the page structure changed to move the 'bottom-all-container' addon container into UIPortalApplication.gtmpl. This change is mainly made to not having to include this dynamic container inside Standalone pages (which hides shared and site layouts) in order to have the same behavior as if the page is retrieved inside the shared layout. This dynamic container, further more, has been renamed in order to avoid having duplication of applications definition inside a same page which had defined its layout before this change (in which case, the addon container will be rendered in UIPortalApplication and the page content as well).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes made in Site Layout Editor MIP, the page structure changed to move the 'bottom-all-container' addon container into UIPortalApplication.gtmpl. This change is mainly made to not having to include this dynamic container inside Standalone pages (which hides shared and site layouts) in order to have the same behavior as if the page is retrieved inside the shared layout. This dynamic container, further more, has been renamed in order to avoid having duplication of applications definition inside a same page which had defined its layout before this change (in which case, the addon container will be rendered in UIPortalApplication and the page content as well).