chore: support proxy environment variables in network requests #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `aiohttp` respects `http_proxy` and `https_proxy` environment variables, improving compatibility with proxied networks.
|
If you need this, please make it an opt-in command line argument. |
|
@AlexCheema That sounds a good idea, I'll handle that. |
This reverts commit f3cb5f5.
- Add `--trust-env` command line argument to enable aiohttp to respect `http_proxy` and `https_proxy` environment variables using monkey patching
wanliqun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--trust-envcommand line argument to enable aiohttp to respecthttp_proxyandhttps_proxyenvironment variables using monkeypatching