Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename bracket-push to matching-brackets #28

Merged
merged 1 commit into from
Apr 15, 2019
Merged

rename bracket-push to matching-brackets #28

merged 1 commit into from
Apr 15, 2019

Conversation

petertseng
Copy link
Member

@petertseng petertseng commented Apr 14, 2019

This rename was proposed in:
exercism/problem-specifications#1501

The rationale for the name is:

  • to name the exercise by its story, not by what it potentially teaches
  • to avoid unnecessarily biasing the solution space

During a transitionary period where some tracks have named this exercise
matching-brackets and some bracket-push, it is helpful if both variants
can have the icon show up in the exercise list.

So, symlink the new name to the old name.
(not applicable; instead, files were uploaded to S3)

When (if?) all tracks complete the rename, the symlinks old files can be deleted from S3.


Open to discussion on whether the old names should be symlinks or copies or something else (not present at all?)

This rename was proposed in:
exercism/problem-specifications#1501

The rationale for the name is:

* to name the exercise by its story, not by what it potentially teaches
* to avoid unnecessarily biasing the solution space
@iHiD iHiD self-assigned this Apr 14, 2019
@iHiD
Copy link
Member

iHiD commented Apr 15, 2019

Thank you. The symlinks won't work because the icons actually get manually uploaded to s3. If you remove the symlinks I will merge the rename though. I've added duplicates on s3 for now.

@petertseng
Copy link
Member Author

I interpreted your message to mean the symlinks should be removed and that no files with the name bracket-push should remain in their place at all. If I have misunderstood and you instead meant that the files should remain, just say the word.

@iHiD iHiD merged commit 0aa0b02 into exercism:master Apr 15, 2019
@iHiD
Copy link
Member

iHiD commented Apr 15, 2019

This is great. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants