Use wasm lib #29
Merged
Use wasm lib #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessByte
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
Very nice.
I would recommend we don't merge this with the github branch for the dependency, but other than that looks great!
Are you also interested in our scripts? I see you wrote your own .sh, but I looked into it and all the JS scripts are compatible as long as your replace require(...) with import at the top. This will also give you the ability to add github actions CI!
|
@SleeplessByte - Reuse sounds attractive! I'll file an issue to do this in a follow-on effort to revisit after the track gets launched. |
|
Looking gooood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest is capped to max 1 worker because of a Jest concurrency issue for how it handles bigints:
Relevant Issue: jestjs/jest#11617