Add queen-attack exercise #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deviated from the auto-generated test suite which only used the Create function for the first few tests and then passed dictionaries representing positions into CanAttack without going through Create. That didn't seem that interesting so I made Create return a dictionary representing a Queen with a stored CanAttack function. Since the first test requires a dictionary be returned, students should hopefully make the connection to storing functions in it. However, this might require an instructions append outlining that Vim script doesn't really have classes so that's why we're using a dictionary and maybe a link about Vim script dictionaries. |
kotp
approved these changes
Nov 5, 2023
kotp
reviewed
Nov 5, 2023
Co-authored-by: Victor Goff <[email protected]>
BNAndras
added
x:module/practice-exercise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #172