Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatten-array exercise #189

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Nov 2, 2023

Related to #172

@BNAndras
Copy link
Member Author

BNAndras commented Nov 2, 2023

I changed the auto-generated tests to use v:null instead of an empty string. The exercise generator should be tweaked in the future if possible to use v:null so a future test sync doesn't break solutions for this exercise by reverting to an empty string representation.

@kotp
Copy link
Member

kotp commented Nov 5, 2023

The exercise generator should be tweaked in the future if possible to use v:null so a future test sync doesn't break solutions for this exercise by reverting to an empty string representation.

Care to create an issue for that?

@BNAndras
Copy link
Member Author

BNAndras commented Nov 5, 2023

Yeah, I’ll file the issue.

@BNAndras
Copy link
Member Author

Okay, my exercises for next month are all ready for your review.

@kotp kotp merged commit 39d859d into exercism:main Nov 10, 2023
4 checks passed
@BNAndras BNAndras deleted the add-flatten-array branch November 10, 2023 17:38
@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants