Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise: Run-length encoding (and decoding) #188

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

kotp
Copy link
Member

@kotp kotp commented Nov 2, 2023

This is currently draft/unfinished/work-in-progress.

Ready for review.

@BNAndras

@kotp kotp force-pushed the run-length-encoding branch 3 times, most recently from bb79196 to 3e1039f Compare November 2, 2023 19:53
@kotp kotp added x:size/medium Medium amount of work x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/medium Medium amount of reputation labels Nov 2, 2023
@kotp kotp self-assigned this Nov 2, 2023
@kotp
Copy link
Member Author

kotp commented Nov 2, 2023

I will work on replicating the tests (as presented via Python) in a few hours.

@kotp kotp force-pushed the run-length-encoding branch 2 times, most recently from 7523867 to 9a60594 Compare November 7, 2023 17:10
@BNAndras
Copy link
Member

BNAndras commented Nov 24, 2023

@kotp. did you want me to take a look? I'm free this weekend. I suspect the problem might be with substitute.

@kotp
Copy link
Member Author

kotp commented Nov 25, 2023

@kotp. did you want me to take a look? I'm free this weekend. I suspect the problem might be with substitute.

Yeah, holidays around here and just have not had time. I would appreciate it!

@BNAndras
Copy link
Member

I sent you a patch over Discord that updates the test suite and example file. The stub needs to be updated so function names match the test suite.

@kotp kotp force-pushed the run-length-encoding branch from 0fcbfc3 to 248acf3 Compare November 25, 2023 20:27
This is currently draft/unfinished/work-in-progress.

ref: #172

Typo, spacing error and expected/actual pattern

Co-authored-by: András B Nagy <[email protected]>
@kotp kotp force-pushed the run-length-encoding branch from 248acf3 to 90d00bc Compare November 26, 2023 02:43
@kotp kotp force-pushed the run-length-encoding branch from 90d00bc to ee621b0 Compare November 26, 2023 02:46
@kotp kotp marked this pull request as ready for review November 26, 2023 03:13
kotp and others added 4 commits November 27, 2023 16:31
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: András B Nagy <[email protected]>
@kotp kotp requested a review from a team November 28, 2023 17:08
@kotp
Copy link
Member Author

kotp commented Nov 28, 2023

@exercism/staff Looks like we may want to have @BNAndras added as a maintainer for this repository.

@ErikSchierboom
Copy link
Member

@kotp Done!

@BNAndras BNAndras merged commit 798ba3d into main Nov 29, 2023
3 checks passed
@BNAndras BNAndras deleted the run-length-encoding branch November 29, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:size/medium Medium amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants