Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pop-count exercise #184

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add pop-count exercise #184

merged 4 commits into from
Nov 10, 2023

Conversation

BNAndras
Copy link
Member

No description provided.

@BNAndras
Copy link
Member Author

BNAndras commented Nov 2, 2023

The exercise name (not the slug itself) was updated recently in problem-specifications so I've accounted for that here. I also moved the exercise to the correct place within the track's exercise array.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This seems to be setting the precedence of sorting by name, rather than slug?

@BNAndras
Copy link
Member Author

BNAndras commented Nov 5, 2023

Yeah, it'd make the most sense to sort by grouped difficulty and then exercise name. That largely matches what we have already done. We can't sort by slug at the moment because the slug for this exercise is pop-count but the user-facing name is Eliud's Eggs. It seems like Jeremy will fix the slug to match the name later.

@BNAndras
Copy link
Member Author

@kotp, can I get a merge?

@kotp kotp merged commit 1b88bcb into exercism:main Nov 10, 2023
3 checks passed
@BNAndras BNAndras deleted the add-pop-count branch November 10, 2023 17:55
@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants