-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darts #177
Add darts #177
Conversation
I’ll troubleshoot tomorrow. The darts tests passed locally. |
Still getting |
All 13 tests pass locally on 8.2 without modification so that's not the problem |
Reviewed my assumptions and I found the culprit. The CI (below) sources each example.vim before running all the tests. for file in glob('exercises/practice/*/.meta/example.vim', 0, 1)
execute 'source' file
endfor |
We should make that not happen. We should be doing this before running each test, and only for the tested folder, not before running all tests. It was just a matter of time before we were going to colide. |
I’ll take a look this weekend. |
@kotp, I renamed Score to DartScore to avoid the original naming issue. We'll still need to deal with the CI in the other PR so it doesn't come up again. |
We could change it to Darts as it describes the game in general. |
Makes sense. I thought briefly about naming it DartToss so I'll revise. |
Related to #172