Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bank-account added #1418

Merged
merged 4 commits into from
Jan 25, 2024
Merged

bank-account added #1418

merged 4 commits into from
Jan 25, 2024

Conversation

TheRealOwenRees
Copy link
Contributor

  • Bank account exercise added
  • Passes local ci checks and tests
  • Tests are a copy of the related JavaScript exercise

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 25, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! CI is failing: https://github.com/exercism/typescript/actions/runs/7653864127/job/20856636786 It's not entirely your fault, but you could run prettier on your added files.

import { BankAccount, ValueError } from './bank-account'

describe('Bank Account', () => {
test('newly opened account has zero balance', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test('newly opened account has zero balance', () => {
it('newly opened account has zero balance', () => {

@TheRealOwenRees
Copy link
Contributor Author

CI now passes it seems. I missed your comment about changing test to it, so I am just doing that now. Thanks for the suggestions.

@ErikSchierboom
Copy link
Member

@TheRealOwenRees Ah, you've ran prettier on all files: https://github.com/exercism/typescript/pull/1418/files#diff-cefa3b7105ddbeabba666110e7894df250177cf5230845999f668ff40d18ba37 Could you revert that? An easy way to do that is to run:

bin/fetch-configlet
bin/configlet sync --docs --update --yes

@ErikSchierboom ErikSchierboom merged commit 0281902 into exercism:main Jan 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants