Update test to use String.prototype.substring() over .substr()
#1417
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There was a problem hiding this comment.
Please remove the unrelated formatting changes.
The replacement for substr is substring, not slice, despite both being almost the same.
|
Ahh gotcha, making the changes now |
Ak5cel
changed the title
String.prototype.slice() over .substr()String.prototype.substring() over .substr()
|
Dropped the previous commits so it's now a clean one with just the refactor. (Syncing my fork on GitHub made that last commit, can remove it or squash them if needed) |
* `String.prototype.substr()` was deprecated, so the test is
updated to use `String.prototype.substring()` instead
|
👍 Cleaned it up so it's now 1 commit rebased to after the latest commits on main |
|
Thanks! |
String.prototype.substr()was deprecated, so the test is refactored to useString.prototype.slice()instead.Edit: Also cleans up formatting with a
yarn formatin the second commit(Fixes #1416, it was auto-closed earlier: PR linked in the forum)