Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bit checking order is reversed in tests #578

Closed
wants to merge 1 commit into from
Closed

bit checking order is reversed in tests #578

wants to merge 1 commit into from

Commits on Oct 11, 2022

  1. bit checking order is reversed in tests 

    I believe the tests for this exercise are written expecting we check the bits from right to left, not left to right as indicated here. `testShuffle1` and `testShuffle3` both pass regardless of which direction we go, but `testShuffle2` fails when going left to right.

If starting with leftmost is the correct behavior, then I believe `testShuffle2` should expect to get `("Purple", "Marigold", "Cyan")` instead of the `("Marigold", "Cyan", "Purple")` it currently wants (I could do a different PR with that change instead of this if that's the right thing).

I might also just be confused and it's correct as is!!
    @BaseCase
    BaseCase authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    cb69856 View commit details
    Browse the repository at this point in the history