Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port Of Palermo] Remove redundant returns in exemplar #1563

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

gabo-cs
Copy link
Contributor

@gabo-cs gabo-cs commented Aug 21, 2023

This PR removes a redundant 'return' statement

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 21, 2023
@kotp kotp reopened this Aug 21, 2023
@kotp
Copy link
Member

kotp commented Aug 21, 2023

I have reopened it. Normally we would want to talk about it in the forums first, but this is something that the exemplar solution should not do. So we can bring it in.

Would you like to remove the other redundant return statement in the other method as well? Might as well take care of both of them while we are here.

@gabo-cs
Copy link
Contributor Author

gabo-cs commented Aug 21, 2023

@kotp Thanks for that! It's done now! And sorry I "bypassed" the forum, didn't know until I saw the bot comment. Appreciate your help.

@gabo-cs gabo-cs changed the title [Port Of Palermo] Remove redundant return in exemplar [Port Of Palermo] Remove redundant returns in exemplar Aug 21, 2023
@kotp
Copy link
Member

kotp commented Aug 21, 2023

@kotp Thanks for that! It's done now! And sorry I "bypassed" the forum, didn't know until I saw the bot comment. Appreciate your help.

No problem. I wish there was a way to get the message out before that happens. But it is what it is.

And we appreciate your help!

@kotp kotp merged commit ba816d4 into exercism:main Aug 21, 2023
3 checks passed
@gabo-cs gabo-cs deleted the gabo-cs-patch-1 branch August 21, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants