Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise: Proverb #742

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Exercise: Proverb #742

merged 8 commits into from
Dec 23, 2024

Conversation

habere-et-dispertire
Copy link
Contributor

@habere-et-dispertire habere-et-dispertire commented Dec 11, 2024

Updated config.json

See this message on the forums

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Dec 11, 2024
@kotp kotp reopened this Dec 12, 2024
@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review December 12, 2024 06:47
exercises/practice/proverb/.DS_Store Outdated Show resolved Hide resolved
@kotp kotp changed the title [ Implementation ] Proverb Exercise: Proverb Dec 23, 2024
@kotp kotp merged commit 85df9b3 into exercism:main Dec 23, 2024
4 checks passed
@habere-et-dispertire
Copy link
Contributor Author

Not sure how, but the stub function should be named "recite" and not proverb :

stub: |-
  sub recite (@nouns) is export {
  }

@kotp : Can you fix this or shall I make a PR?

@kotp
Copy link
Member

kotp commented Dec 23, 2024

Not sure how, but the stub function should be named "recite" and not proverb :

stub: |-
  sub recite (@nouns) is export {
  }

@kotp : Can you fix this or shall I make a PR?

Make a PR I will get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants