Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card Games] Update 'approx_average_is_average' docstring summary #3675

Conversation

anym0us
Copy link
Contributor

@anym0us anym0us commented Apr 15, 2024

Improve docstring summary of approx_average_is_average function to be more clear. This is a fix for #3674.

A story behind

  1. Initially I've started an implementation of approx_average_is_average function based on docstring.
  2. Wrote the function, run tests and found the implementation doesn't work.
  3. Then read instructions and found inconsistencies between docstring and instructions (see the screenshot below).

Screenshot

Screen Shot 2024-04-14 at 8 01 37 PM

This comment was marked as resolved.

@github-actions github-actions bot closed this Apr 15, 2024
@anym0us
Copy link
Contributor Author

anym0us commented Apr 15, 2024

@BethanyG, hi! 👋 Could you re-open the PR, please?

@BethanyG BethanyG reopened this Apr 15, 2024
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this! 🌈

@BethanyG BethanyG merged commit cca033b into exercism:main Apr 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants