Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matching Brackets] draft approaches #3670

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

colinleach
Copy link
Contributor

This one ended up less short and boring than I expected, with benchmarking totally invalidating my predictions!

As an aside, this is the second approaches submission that needs to refer to Walrus operators - now occurring regularly in community solutions. Whatever the low current priority of the learning syllabus, it would make my life easier to have PR #3585 merged so that we can reference it.

@colinleach
Copy link
Contributor Author

Do you have any idea why configlet has started insisting that .articles/performance/snippet.md must exist and can't be empty? It seems a bit silly.

@BethanyG
Copy link
Member

BethanyG commented Apr 8, 2024

Do you have any idea why configlet has started insisting that .articles/performance/snippet.md must exist and can't be empty? It seems a bit silly.

No clue, really. Probably trying to be "helpful" by linting. A question for Erik, methinks.

@colinleach
Copy link
Contributor Author

OK, thanks. I'll put something on the forum.

@colinleach
Copy link
Contributor Author

Welcome back! I am, as usual, very happy with your changes.

Copy link
Contributor Author

@colinleach colinleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes

Hopefully, the final edits.  😄
@BethanyG
Copy link
Member

BethanyG commented Aug 1, 2024

Tryin' to make my way back, slowly. 😅 . Just about done with this, and after one more once-over, will approve and merge!

@colinleach
Copy link
Contributor Author

In your own time. Let me know if there's anything I can do to help.

I'm also feeling my way back in. Today's submission (julia/two-bucket) was my first solution for >2 months.

@BethanyG
Copy link
Member

BethanyG commented Aug 1, 2024

Alrighty. Let's hope that I didn't re-confuse left vs right. I think everything's all good...so pushing the big, green button! 🚀

@BethanyG BethanyG merged commit bcb5300 into exercism:main Aug 1, 2024
8 checks passed
@BethanyG
Copy link
Member

BethanyG commented Aug 1, 2024

WOOT! One down, 17 more to go.......

@colinleach
Copy link
Contributor Author

Yeah, I don't think I'll PR any more just yet (for so many reasons)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants