Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct capitalization of 'atbash' to 'Atbash' #2485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tasxatzial
Copy link
Member

No description provided.

@tasxatzial tasxatzial requested a review from a team as a code owner October 22, 2024 21:02
@BNAndras
Copy link
Member

Although all monoalphabetic ciphers are weak, the affine cipher is much stronger than the atbash cipher, because it has many more keys.
includes another lowercased Atbash reference.

@BNAndras
Copy link
Member

Also, if it doesn't cause additional churn for tracks with test generators, the comments in atbash-cipher tests.toml also use the lowercased Atbash.

@tasxatzial
Copy link
Member Author

tasxatzial commented Oct 22, 2024

So far 'Atbash' is incorrectly capitalized in:

Although all monoalphabetic ciphers are weak, the affine cipher is much stronger than the atbash cipher, because it has many more keys.

blurb = "Create an implementation of the atbash cipher, an ancient encryption system created in the Middle East."

"* Encoding from English to atbash cipher",

"* Decoding from atbash cipher to all-lowercase-mashed-together English"

I'll update those too, if needed. I just need to know which ones.

Edit: I guess the affine-cipher instructions need to be fixed for sure.

@IsaacG
Copy link
Member

IsaacG commented Oct 23, 2024

I think it would be good to update them all to be consistent.

@tasxatzial tasxatzial changed the title atbash-cipher: Correct capitalization of 'atbash' to 'Atbash' in instructions Correct capitalization of 'atbash' to 'Atbash' Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants