Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "proteins"->"amino acids" in protein-translation description table #2478

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Rename "proteins"->"amino acids" in protein-translation description table #2478

wants to merge 9 commits into from

Conversation

0xNeshi
Copy link

@0xNeshi 0xNeshi commented Sep 22, 2024 •
edited
Loading

Closes #1639

Related forum discussion

@0xNeshi 0xNeshi marked this pull request as ready for review September 23, 2024 07:46
@0xNeshi 0xNeshi requested a review from a team as a code owner September 23, 2024 07:46
@0xNeshi 0xNeshi self-assigned this Sep 23, 2024
@IsaacG
Copy link
Member

IsaacG commented Sep 24, 2024

Would you mind starting a discussion on the forum about this first?

@0xNeshi
Copy link
Author

0xNeshi commented Sep 24, 2024

Would you mind starting a discussion on the forum about this first?

I reverted all the changes not related to #1639 . Will open a discussion at a later point

@IsaacG
Copy link
Member

IsaacG commented Sep 24, 2024

I reverted all the changes not related to #1639 . Will open a discussion at a later point

Exercism policy is to resolve a forum discussion prior to opening a PR.

@Cool-Katt
Copy link
Contributor

@0xNeshi - Open a discussion on the forum here with the changes you want to make (discussed in the issue you reference) and then open a PR after that (or in this case you can reference this PR but for the future, please keep to the policy).

@0xNeshi 0xNeshi changed the title Rename proteins->polypeptide in protein-translation canonical-data.json Rename "proteins"->"amino acids" in protein-translation description table Sep 25, 2024
@0xNeshi 0xNeshi marked this pull request as draft September 25, 2024 18:51
@0xNeshi 0xNeshi marked this pull request as ready for review September 30, 2024 13:49
Cool-Katt
Cool-Katt reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Cool-Katt Cool-Katt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@0xNeshi
Copy link
Author

0xNeshi commented Oct 24, 2024

Just curios, what else is necessary to prompt the PR to get merged?

@BethanyG
Copy link
Member

BethanyG commented Oct 24, 2024 •
edited
Loading

Looks like it needs a maintainers-admin group member to approve. iHiD approval should have done it (IIRC it is he and Erik in that group), but I think permissions have been a bit funky since we've re-arranged teams.

Which means @ErikSchierboom (or an adjustment to codeowners).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG approved these changes

@iHiD iHiD iHiD approved these changes

@BethanyG BethanyG BethanyG approved these changes

@BNAndras BNAndras BNAndras approved these changes

@Cool-Katt Cool-Katt Cool-Katt approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees

@0xNeshi 0xNeshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protein Translation: task description, "codon to amino acid" table improvement
6 participants
@0xNeshi @IsaacG @Cool-Katt @BethanyG @iHiD @BNAndras