knapsack: split introduction and instructions #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennj
approved these changes
May 15, 2024
IsaacG
approved these changes
May 15, 2024
IsaacG
reviewed
May 16, 2024
exercises/knapsack/introduction.md
Outdated
| After months of careful planning, he finally manages to crack the security systems of a fancy store. | ||
|
|
||
| In front of him are many items, each with a value and weight. | ||
| Whilst Bob would gladly take all of the items, his knapsack can only hold so much weight. |
There was a problem hiding this comment.
Whilst is not a word I see used often. What about the simpler,
Suggested change
| Whilst Bob would gladly take all of the items, his knapsack can only hold so much weight. | |
| Bob would gladly take all of the items, but his knapsack can only hold so much weight. |
Co-authored-by: Isaac Good <[email protected]>
ErikSchierboom
commented
May 16, 2024
ErikSchierboom
commented
May 16, 2024
ErikSchierboom
commented
May 16, 2024
MatthijsBlom
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.