kindergarten-garden: split description into introduction and instructions #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
commented
May 15, 2024
|
|
||
| They've chosen to grow grass, clover, radishes, and violets. | ||
| - Grass ("G"), clover ("C"), radishes ("R"), and violets ("V") |
There was a problem hiding this comment.
I've added the character encoding the plant this time.
There was a problem hiding this comment.
Would a table make sense here or is that overkill?
There was a problem hiding this comment.
🤷♂️ What do others do think?
There was a problem hiding this comment.
I'm for adding the table. It's not clear what those strings are for at this point since we don't have the examples yet.
If we don't want a table, we can do a sentence like Grass is marked on the diagram by "G", clover by "C", radishes by "R", and violets by "V".
There was a problem hiding this comment.
I've added a table.
glennj
reviewed
May 15, 2024
glennj
approved these changes
May 15, 2024
Co-authored-by: Glenn Jackman <[email protected]>
BNAndras
approved these changes
May 15, 2024
IsaacG
approved these changes
May 15, 2024
|
|
||
| They've chosen to grow grass, clover, radishes, and violets. | ||
| - Grass ("G"), clover ("C"), radishes ("R"), and violets ("V") |
There was a problem hiding this comment.
Would a table make sense here or is that overkill?
Co-authored-by: András B Nagy <[email protected]>
ErikSchierboom
force-pushed
the
kindergarten-garden
branch
from
6f5af33
to
0c6e851
Compare
BNAndras
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.