Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anagram: split description into instructions and introduction #2438

Merged
merged 5 commits into from
May 16, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from a team as a code owner May 15, 2024 10:08
However, your excitement wanes when you examine the output: all words are garbled!
For example, it prints "liar" instead of "rail" and "pots" instead of "stop."
Carefully, you try again, but the result is the same.
Apparently, all keys are wired incorrectly; for instance, the "r" key outputs an "l" and vice versa.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such faulty but fixed wiring would not effectively generate anagrams. It could only work for words that consist entirely of permutation cycles. Most output would not be anagrams of anything.

I reckon a variable delay would work better: you'd still get all the letters you type, just probably in a different order.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated. Could you check again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this works 👍

@ErikSchierboom ErikSchierboom merged commit 34da1fa into main May 16, 2024
7 checks passed
@ErikSchierboom ErikSchierboom deleted the anagram-split branch May 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants