Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync atbash-cipher #847

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sync atbash-cipher #847

wants to merge 3 commits into from

Conversation

tomasnorre
Copy link
Contributor

Resolves #839

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 9, 2024
@tomasnorre tomasnorre marked this pull request as ready for review November 11, 2024 16:36
mk-mxp
mk-mxp requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a function stub for decode() to the students file.

Everything else looks great, maybe a small improvement to ease the itches of an array_search() for each character.

exercises/practice/atbash-cipher/.meta/example.php Outdated Show resolved Hide resolved
@tomasnorre
Copy link
Contributor Author

Better now?

@tomasnorre
Copy link
Contributor Author

tomasnorre commented Nov 12, 2024 •
edited
Loading

I cannot reproduce the problem with the composer lint:check locally.

Edit: I can now after an composer update looks like something change in one of the dependencies. I'll try to look into it. It's the same for the Bowling PR #856

@mk-mxp
Copy link
Contributor

mk-mxp commented Nov 12, 2024 •
edited
Loading

It's about to be solved: We should follow PHPCS naming conventions as soon as possible.

If you want to provide a PR fixing it really, use Commenting category like here.

@tomasnorre
Copy link
Contributor Author

tomasnorre commented Nov 12, 2024 •
edited
Loading

It's about to be solved: We should follow PHPCS naming conventions as soon as possible.

If you want to provide a PR fixing it really, use Commenting category like here.

I just saw it just now too.
Edit: There is already a PR in progress, which solves the problem. PHPCSStandards/PHP_CodeSniffer#676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tomasnorre tomasnorre

Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync atbash-cipher
2 participants
@tomasnorre @mk-mxp