Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SimpleCipher test cases and test class definion #590

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Added SimpleCipher test cases and test class definion #590

merged 6 commits into from
Sep 18, 2023

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Sep 15, 2023

@Bajger Bajger self-assigned this Sep 15, 2023
@Bajger Bajger added exercise This issue concerns an exercise new exercise implementation x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/medium Medium amount of work labels Sep 15, 2023
@Bajger
Copy link
Contributor Author

Bajger commented Sep 15, 2023

@glennj Please take a look at solution. This wasn't really my favorite exercise :) I believe there are nicer ways to implement solution. Tests are passing for this exercise. Will add rest of metadata (config and /exercise/simple-cipher later).

glennj
glennj approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Of course the example solution does not need to be the "exemplar".

@Bajger Bajger merged commit fa29b3b into exercism:main Sep 18, 2023
4 checks passed
@Bajger Bajger deleted the 589-Add-Simple-Cipher-exercise branch September 18, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennj glennj glennj approved these changes

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees

@Bajger Bajger

Labels
exercise This issue concerns an exercise new exercise implementation x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/medium Medium amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Simple Cipher exercise
3 participants
@Bajger @glennj @ErikSchierboom