Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution to Gigsecond exercise #319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carlotxra
Copy link
Contributor

Used *exercism extension method on DateAndTime to test if possible to use it.

@macta
Copy link
Contributor

macta commented May 1, 2019

Extensions do t work yet - we are testing the move from tags to full packages which makes it possible (probably 1 week away)

Make is explicit that we're adding seconds and not just an integer.
@carlotxra
Copy link
Contributor Author

Ok no problem, thanks for letting me know. It will be helpful to be able to use extension methods in some of the exercises. Anyway I updated the code and removed it for now.

@macta
Copy link
Contributor

macta commented May 2, 2019

Yes - we want extension methods hence the move to full packages now we’ve understood the Pharo direction on tags can projects. Short story - we need full packages which creates a different pain for all our exercises but one I’ve midtly resolved now - just need some testing. So thanks for working around it for now

@bencoman
Copy link
Contributor

@carlotxra We now have extension methods working by moving exercises from package-tags to full-packages - but this means this PR can't be directly merged. Would it be possible for you to redo it based off current master branch?

Base automatically changed from master to main January 28, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants