IF the submission id is missing, retrieve it and try again (#228)

exercism · Apr 1, 2019 · 72a8f73 · 72a8f73
1 parent e43fdae
commit 72a8f73
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 5 deletions.
diff --git a/dev/src/ExercismTools/ExSolutionIdError.class.st b/dev/src/ExercismTools/ExSolutionIdError.class.st
@@ -0,0 +1,5 @@
+Class {
+	#name : #ExSolutionIdError,
+	#superclass : #ExercismError,
+	#category : #'ExercismTools-Core'
+}
diff --git a/dev/src/ExercismTools/ExercismError.class.st b/dev/src/ExercismTools/ExercismError.class.st
@@ -1,3 +1,6 @@
+"
+I am a hierarchy of Exercism errors, so its east to catch them
+"
 Class {
 	#name : #ExercismError,
 	#superclass : #Error,

diff --git a/dev/src/ExercismTools/ExercismExercise.class.st b/dev/src/ExercismTools/ExercismExercise.class.st
@@ -325,6 +325,11 @@ ExercismExercise >> topics: aStringArray [
 	topics := aStringArray
 ]
 
+{ #category : #accessing }
+ExercismExercise >> trackId [
+	^ExercismManager trackId
+]
+
 { #category : #accessing }
 ExercismExercise >> unlockReference [
 	"Answer the String unlock reference for a non-core exercise, otherwise nil"

diff --git a/dev/src/ExercismTools/ExercismFetchCommand.class.st b/dev/src/ExercismTools/ExercismFetchCommand.class.st
@@ -42,3 +42,8 @@ ExercismFetchCommand >> parser [
 ExercismFetchCommand >> parser: aTonelParser [
 	parser := aTonelParser
 ]
+
+{ #category : #internal }
+ExercismFetchCommand >> retrieveLatestData [
+	^self subclassResponsibility 
+]
diff --git a/dev/src/ExercismTools/ExercismSubmitCommand.class.st b/dev/src/ExercismTools/ExercismSubmitCommand.class.st
@@ -32,11 +32,19 @@ ExercismSubmitCommand class >> from: anHttpClient exercise: exercise [
 
 { #category : #execution }
 ExercismSubmitCommand >> execute [
-	^ self
-		executeCheckingToken: [ 
-			self httpClient
+	^ [ self
+		executeCheckingToken: [ self httpClient
 				patchSolution: self exercise solutionId
-				with: self exercise solutionSources ]
+				with: self exercise solutionSources ] ]
+		on: ExSolutionIdError
+		do: [ :error | 
+			| submission |
+
+			submission := (ExercismDownloadCommand
+				track: self exercise trackId
+				exercise: self exercise name) fetchLatestSubmission.
+			submission storeSolutionId.
+			error retry ]
 ]
 
 { #category : #accessing }

diff --git a/dev/src/ExercismTools/ExercismTest.class.st b/dev/src/ExercismTools/ExercismTest.class.st
@@ -56,7 +56,7 @@ ExercismTest class >> next [
 
 { #category : #accessing }
 ExercismTest class >> solutionId [
-	^ solutionId ifNil: [ 'missingSolutionId' ]
+	^ solutionId ifNil: [ ExSolutionIdError signal: 'Missing exercise solutionId' ]
 ]
 
 { #category : #accessing }