bracket-push: rename to matching-brackets #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rename was proposed in: exercism/problem-specifications#1501 The rationale for the name is: * to name the exercise by its story, not by what it potentially teaches * to avoid unnecessarily biasing the solution space
SleeplessByte
added
the
sync 🔄
tejasbubane
approved these changes
Apr 15, 2019
|
Is it ok to merge this before the problem-spec PR is merged? |
|
These two have already been merged so I expect it's fine! |
|
Yes, I saw the haskell PR. But this comment made me think again: exercism/problem-specifications#1495 (comment) |
|
I suggest holding off until problem-spec is updated - just as a precaution for issues like ones with |
|
FWIW exercism/csharp#1276 did get merged. I agree with holding-off; let's see what happens with that :) |
|
exercism/problem-specifications#1501 got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename was proposed in:
exercism/problem-specifications#1501
The rationale for the name is: