Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mixed Juices] Fix hints' reference to MDN's fall-though section #2453

Conversation

anym0us
Copy link
Contributor

@anym0us anym0us commented Apr 29, 2024

MDN switch documentation has been updated some time ago, so section references has been changed.

This PR fixes the reference to fall-through section in tasks' hints.

Screenshot

Screen Shot 2024-04-28 at 6 55 20 PM

Proposed change

Currently Suggested
https://eveloper.mozilla.org/en-US/docs/.../ switch#what_happens_if_i_forgot_a_break https://developer.mozilla.org/en-US/docs/.../ switch#breaking_and_fall-through
Screen Shot 2024-04-28 at 6 58 47 PM Screen Shot 2024-04-28 at 6 59 02 PM

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 29, 2024
@anym0us
Copy link
Contributor Author

anym0us commented Apr 29, 2024

@SleeplessByte Hello! 👋 Please could you have a look, once you have a minute? 🙏 I've re-created a PR.

@SleeplessByte SleeplessByte added the x:size/small Small amount of work label Apr 29, 2024
@SleeplessByte SleeplessByte merged commit a9e5cec into exercism:main Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants