Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eliud's eggs exercise #1279

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

c0m3tx
Copy link

@c0m3tx c0m3tx commented Oct 30, 2024

Added Haskell practice exercise "Eliud's eggs" based on the available problem specification.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 30, 2024
@iHiD iHiD reopened this Oct 31, 2024
"runtime/standalone_executable",
"typing/static",
"typing/strong",
"used_for/backends",
"used_for/financial_systems"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this file has changed, which seems unrelated to the exercise being added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running configlet create --practice-exercise <slug> formats the track config as if the user had also run configlet fmt. So if this was the first Haskell exercise added since that functionality was added, the noise makes sense. The next Haskell exercise PR though shouldn't have this noise since the config would be already correctly formatted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was also a bit confused when I ran the configlet cmd to be honest 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BNAndras I defer to you! :)

@c0m3tx c0m3tx marked this pull request as ready for review October 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants