Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in checks for letters and punctuation #1217

Closed
wants to merge 1 commit into from

Conversation

dr-impossible
Copy link
Contributor

The test cases "invalid with letters" and "invalid with punctuations" have area codes which begin with '1', which could cause the code under test to reject the number (instead of rejecting it for having letters or symbols). I've changed the tests to be more specific in triggering the case of a phone number containing letters or symbols.

For example, this community solution should fail these two tests

The test cases "invalid with letters" and "invalid with punctuations" have area codes which begin with '1', which could cause the code under test to reject the number (instead of rejecting it for having letters or symbols). I've changed the tests to be more specific in triggering the case of a phone number containing letters or symbols.

For example, this community solution should fail these two tests: https://exercism.org/tracks/haskell/exercises/phone-number/solutions/frederickjeanguerin
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant