reference/concepts.md: Update concepts completed; README: Add instructions.md and config.json to practice exercise structure #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

petertseng merged 2 commits into exercism:main from pwadsworth:main

Oct 1, 2022

Contributor

pwadsworth commented Sep 21, 2022 •

edited by petertseng

Loading

Updates reference/concepts with concepts already covered.
Updates README to reflect current directory structure (closes README: Practice exercise directory structure doesn't show .meta/config.json nor .docs/instructions.md #1085)

petertseng reviewed

View reviewed changes

config.json Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

Member

petertseng left a comment

commit messages need to describe the change made in words, not just "closes issue". Without an internet connection it's not possible to know what the issue is. For example, "README: correct exercise structure for practice exercises"

petertseng reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

reference/concepts.md Outdated Show resolved Hide resolved

petertseng reviewed

View reviewed changes

reference/concepts.md Outdated

                 - [ ] Queues
                 - [ ] Sets
                 - [ ] Stacks
-              - [ ] Algebraic data types
+              - [x] Algebraic data types

Member

petertseng Sep 21, 2022

I can't agree that we've covered these. I would have had to see an exercise explaining data, but I don't see one

Contributor Author

pwadsworth Sep 26, 2022

ADTs and data are WIP under #1110. The idea being PR #1110 will be finished prior to this one.

Member

petertseng Oct 1, 2022

Well since I intend to merge this now, before #1110, I'm removing this change. Resubmit it after #1110 is done, or just include this change in #1110.

petertseng reviewed

View reviewed changes

config.json Outdated Show resolved Hide resolved

pwadsworth force-pushed the main branch 3 times, most recently from 3085cb4 to f9ef508 Compare

October 1, 2022 01:36

pwadsworth added 2 commits

October 1, 2022 10:07


          reference/concepts.md: Update concepts completed

2e01022


          README: Add instructions.md and config.json to practice exercise stru…

825e382

…cture

Closes exercism#1085

petertseng force-pushed the main branch from f9ef508 to 825e382 Compare

October 1, 2022 10:17

petertseng changed the title ~~Updates progress in concept development~~ reference/concepts.md: Update concepts completed; README: Add instructions.md and config.json to practice exercise structure

petertseng approved these changes

View reviewed changes

petertseng merged commit f65f903 into exercism:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet