Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Knapsack" exercise #2757

Merged
merged 6 commits into from
Jul 13, 2024

Conversation

jesse-kroon
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 1, 2024
@andrerfcsantos andrerfcsantos reopened this Feb 1, 2024
@jesse-kroon jesse-kroon marked this pull request as ready for review February 1, 2024 08:45
@andrerfcsantos andrerfcsantos added the x:rep/large Large amount of reputation label Jul 13, 2024
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this exercise added!

Since it's been a while since we last talked and to make you not have to revisit this, I made a couple of tweaks in your branch:

  • Made Item public. Usually types given to the student in the track are always public by default.
  • Ran configlet sync for the exercise, which separated the instructions into instructions.md and introduction.md.
  • Added a benchmark function. All practice exercises have this.
  • Increased the difficulty of the exercise to 6, to make it in line with other dynamic programming exercises.
  • Tweaked the comment in the function given to the student

Thanks a lot for all the work!

@andrerfcsantos andrerfcsantos merged commit 788fec9 into exercism:main Jul 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants