Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for lucians-luscious-lasagna with datatype #1268

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

s-praveen-kumar
Copy link
Contributor

This concept introduces datatypes, both type inference and explicit type annotation is covered. As a beginner I felt really confused as to what type should I annotate my functions with and is it even needed. (I was trying uint and was constantly getting lots of errors). Hence adding a note on the type expectation for future learners.

This concept introduces datatypes, both type inference and explicit type annotation is covered.
As a beginner I felt really confused as to what type should I annotate my functions with and is it even needed. (I was trying uint and was constantly getting lots of errors). Hence adding a note on the type expectation for future learners.
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 8, 2024
@ErikSchierboom
Copy link
Member

The introduction has this section:

Bindings are defined using the let keyword. Specifying a binding's type is optional for most bindings, as F#'s type inference can usually infer the type based on their value. A binding looks like this:

Your argument is that this is not enough to go on?

@s-praveen-kumar
Copy link
Contributor Author

Hi @ErikSchierboom
My point was, the learning material introduces both type inference and explicit type annotation. But I was not sure which one to use for the exercise.

At least when I attempted as a beginner, I was annotating different types and was getting error messages.

@ErikSchierboom
Copy link
Member

Makes sense. I don't have much time now, but I'll come back to this!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ErikSchierboom ErikSchierboom merged commit cc54d29 into exercism:main Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants