Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts based on recent configlet changes #296

Open
devkabiir opened this issue Feb 17, 2021 · 8 comments · Fixed by #301
Open

Update scripts based on recent configlet changes #296

devkabiir opened this issue Feb 17, 2021 · 8 comments · Fixed by #301
Assignees
Labels
v3-migration 🤖 Preparing for Exercism v3 v3 Preparing for Exercism

Comments

@devkabiir
Copy link
Contributor

devkabiir commented Feb 17, 2021

I noticed in the recent PR #295, that our check_formatting is running configlet lint manually, which is no longer required since #283 added a separate workflow for it.

The following scripts need to be updated:

configlet fmt is not supported at the moment. Maybe later

Originally posted by @ErikSchierboom in #301 (comment)

devkabiir added a commit that referenced this issue Feb 18, 2021
devkabiir added a commit that referenced this issue Feb 18, 2021
* Don't run configlet lint manually in check_formatting.dart

* 🐛  (exercises/concepts) Add stub content to dart files

This is to allow dart formatting checks to pass in CI

* 🚧  (presubmit) Temporarily disable `configlet fmt`

Please see #296
@devkabiir devkabiir reopened this Feb 18, 2021
@Stargator Stargator added the v3 Preparing for Exercism label Mar 4, 2021
@Stargator
Copy link
Contributor

@devkabiir I'm going to start looking into this ticket.

@Stargator Stargator self-assigned this Jul 25, 2021
@Stargator Stargator added the v3-migration 🤖 Preparing for Exercism v3 label Jul 25, 2021
@Stargator
Copy link
Contributor

@devkabiir It does seem like #301 resolves this issue. Is there something else related to this?

@devkabiir
Copy link
Contributor Author

I think the presubmit script hasn't been updated.

@Stargator
Copy link
Contributor

Stargator commented Oct 16, 2021

@devkabiir Okay, I'll address that in my branch. Thanks

But it looks like configlet still doesn't have a format option, so that part will likely have to wait

@ErikSchierboom
Copy link
Member

But it looks like configlet still doesn't have a format option, so that part will likely have to wait

That is correct. We don't yet have that, but we will at some point :)

@Stargator
Copy link
Contributor

@ErikSchierboom Has configlet been updated to format the config files?

@kytrinyx
Copy link
Member

@Stargator configlet formats exercise config files, but does not yet format the track-level config file.

@Stargator
Copy link
Contributor

@devkabiir Updated the original post to track the other scripts that need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3-migration 🤖 Preparing for Exercism v3 v3 Preparing for Exercism
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants