Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test runner to use the new path for example implementation #299

Closed
devkabiir opened this issue Feb 18, 2021 · 3 comments · Fixed by #300
Closed

Update test runner to use the new path for example implementation #299

devkabiir opened this issue Feb 18, 2021 · 3 comments · Fixed by #300

Comments

@devkabiir
Copy link
Contributor

Per #298, example implementations are moved from lib/example.dart to .meta/lib/example.dart. This breaks the existing test runner.

Relevant:

@iHiD
Copy link
Member

iHiD commented Feb 18, 2021

@devkabiir Is this as simple as changing the line you specified (and the one a few lines down), or is there something more complex that needs doing?

@devkabiir
Copy link
Contributor Author

devkabiir commented Feb 18, 2021

Yes it should work see #300.

But there's also #296 blocking the Test workflow from running altogether. To unblock Test, relevant lines that need to be removed are https://github.com/exercism/dart/blob/main/bin/check_formatting.dart#L8-L17

And finally the following line might need updating as well, since I don't know if the latest version of configlet supports the configlet fmt . command.

await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);

These are quite simple changes, but I can't approve my own PR.

@iHiD
Copy link
Member

iHiD commented Feb 18, 2021

If you tag @exercism/maintainers-admin into any PRs, Erik will approve them for you :)

@Stargator Stargator added v3 Preparing for Exercism and removed v3-migration 🤖 labels Mar 21, 2021
@Stargator Stargator added this to the Setup for Exercism V3 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants