Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exceptions from football match reports #2322

Merged

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Oct 30, 2024

Exceptions are introduced in a later concept and should be removed here.

Fixes #2306

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ErikSchierboom ErikSchierboom merged commit 6397978 into exercism:main Oct 30, 2024
6 checks passed
@vaeng vaeng deleted the football-reports-remove-exceptions branch October 30, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footbal match reports exercise should depend on Exceptions first exercise
2 participants