Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bird-watcher: Fix introduction example #690

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

caioguedes
Copy link
Contributor

@caioguedes caioguedes commented Oct 26, 2024

Small fix in an example that can't be evaluated.

I am not sure if could be better move the example to:

(def three-values [4 5 6])

as the exercise is presented in part of the Numbers path... What do you thing?

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 26, 2024
@tasxatzial tasxatzial reopened this Oct 26, 2024
Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Since the preceding paragraph says "heterogenous types", it's probably best if we use a vector that has items of different types.

With this change we'll also be consistent with the article that introduces the concept of vectors:

https://exercism.org/tracks/clojure/concepts/vectors

exercises/concept/bird-watcher/.docs/introduction.md Outdated Show resolved Hide resolved
@IsaacG
Copy link
Member

IsaacG commented Oct 27, 2024

@tasxatzial tasxatzial added the x:rep/small Small amount of reputation label Oct 28, 2024
@tasxatzial tasxatzial merged commit a06e645 into exercism:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants