-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list-ops exercise (WIP) #623
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
081276c
Add list-ops exercise
kahgoh 3e1954c
Merge branch 'main' of github.com:exercism/clojure into exercise/list…
kahgoh bc375ba
Merge remote-tracking branch 'exercism/main' into exercise/list-ops
kahgoh 0509753
Fix link to example
kahgoh 9930f51
Add prerequisites & trim whitespace
kahgoh 8ca6bc0
Fix list-ops test
kahgoh 3814994
Add back generator.clj and remove unneeded comments from list_ops.clj
kahgoh 53cd83d
Rename list functions
kahgoh beedaca
Change list references to collection
kahgoh 7be9dc4
Change references to vectors
kahgoh aeb8e53
Apply suggestions from code review
kahgoh 622a6be
Add instructions.append
tasxatzial 9fd1779
also change 'series' to 'vector'
tasxatzial 90768ca
Add tasxatzial as contributer
kahgoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Instructions append | ||
|
||
## Implementation tips | ||
|
||
- The instructions use lists because they are synced with a shared repository to maintain consistency across tracks. | ||
However, for this exercise in the Clojure track, you should assume that you are working with vectors instead of lists. | ||
- It is important not to reuse existing Clojure built-in functions with similar functionality, as doing so would diminish the intended learning value of the exercise. | ||
Some of these functions include `into`, `concat`, `cat`, `lazy-cat`, `mapcat`, `flatten`, `filter`, `filterv`, `remove`, `count`, `map`, `mapv`, `reduce`, `transduce`, `reverse`, and `rseq` from the **clojure.core** namespace. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Instructions | ||
|
||
Implement basic list operations. | ||
|
||
In functional languages list operations like `length`, `map`, and `reduce` are very common. | ||
Implement a series of basic list operations, without using existing functions. | ||
|
||
The precise number and names of the operations to be implemented will be track dependent to avoid conflicts with existing names, but the general operations you will implement include: | ||
|
||
- `append` (_given two lists, add all items in the second list to the end of the first list_); | ||
- `concatenate` (_given a series of lists, combine all items in all lists into one flattened list_); | ||
- `filter` (_given a predicate and a list, return the list of all items for which `predicate(item)` is True_); | ||
- `length` (_given a list, return the total number of items within it_); | ||
- `map` (_given a function and a list, return the list of the results of applying `function(item)` on all items_); | ||
- `foldl` (_given a function, a list, and initial accumulator, fold (reduce) each item into the accumulator from the left_); | ||
- `foldr` (_given a function, a list, and an initial accumulator, fold (reduce) each item into the accumulator from the right_); | ||
- `reverse` (_given a list, return a list with all the original items, but in reversed order_). | ||
|
||
Note, the ordering in which arguments are passed to the fold functions (`foldl`, `foldr`) is significant. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"authors": [ | ||
"bobbicodes" | ||
], | ||
"contributors": [ | ||
"kahgoh", | ||
"tasxatzial" | ||
], | ||
"files": { | ||
"solution": [ | ||
"src/list_ops.clj" | ||
], | ||
"test": [ | ||
"test/list_ops_test.clj" | ||
], | ||
"example": [ | ||
".meta/src/example.clj" | ||
] | ||
}, | ||
"blurb": "Implement basic list operations." | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
(ns list-ops) | ||
|
||
(defn foldl [f coll init] | ||
(loop [acc init l coll] | ||
(cond | ||
(empty? l) acc | ||
:else (recur (f acc (first l)) (rest l))))) | ||
|
||
(defn append [coll1 coll2] | ||
(list-ops/foldl (fn [acc elem] (conj acc elem)) coll2 coll1)) | ||
|
||
(defn concatenate [coll] | ||
(cond | ||
(empty? coll) [] | ||
:else (list-ops/foldl (fn [acc elem] (list-ops/append acc elem)) (rest coll) (first coll)))) | ||
|
||
(defn select-if [pred coll] | ||
(loop [acc [] l coll] | ||
(cond | ||
(empty? l) acc | ||
(pred (first l)) (recur (conj acc (first l)) (rest l)) | ||
:else (recur acc (rest l))))) | ||
|
||
(defn length [coll] | ||
(list-ops/foldl (fn [acc elem] (+ acc 1)) coll 0)) | ||
|
||
(defn apply-to-each [f coll] | ||
(list-ops/foldl (fn [acc elem] (conj acc (f elem))) coll [])) | ||
|
||
(defn reverse-order [coll] | ||
(list-ops/foldl (fn [acc elem] (cons elem acc)) coll [])) | ||
|
||
(defn foldr [f coll init] | ||
(list-ops/foldl f (list-ops/reverse-order coll) init)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
# This is an auto-generated file. | ||
# | ||
# Regenerating this file via `configlet sync` will: | ||
# - Recreate every `description` key/value pair | ||
# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications | ||
# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) | ||
# - Preserve any other key/value pair | ||
# | ||
# As user-added comments (using the # character) will be removed when this file | ||
# is regenerated, comments can be added via a `comment` key. | ||
|
||
[485b9452-bf94-40f7-a3db-c3cf4850066a] | ||
description = "append entries to a list and return the new list -> empty lists" | ||
|
||
[2c894696-b609-4569-b149-8672134d340a] | ||
description = "append entries to a list and return the new list -> list to empty list" | ||
|
||
[e842efed-3bf6-4295-b371-4d67a4fdf19c] | ||
description = "append entries to a list and return the new list -> empty list to list" | ||
|
||
[71dcf5eb-73ae-4a0e-b744-a52ee387922f] | ||
description = "append entries to a list and return the new list -> non-empty lists" | ||
|
||
[28444355-201b-4af2-a2f6-5550227bde21] | ||
description = "concatenate a list of lists -> empty list" | ||
|
||
[331451c1-9573-42a1-9869-2d06e3b389a9] | ||
description = "concatenate a list of lists -> list of lists" | ||
|
||
[d6ecd72c-197f-40c3-89a4-aa1f45827e09] | ||
description = "concatenate a list of lists -> list of nested lists" | ||
|
||
[0524fba8-3e0f-4531-ad2b-f7a43da86a16] | ||
description = "filter list returning only values that satisfy the filter function -> empty list" | ||
|
||
[88494bd5-f520-4edb-8631-88e415b62d24] | ||
description = "filter list returning only values that satisfy the filter function -> non-empty list" | ||
|
||
[1cf0b92d-8d96-41d5-9c21-7b3c37cb6aad] | ||
description = "returns the length of a list -> empty list" | ||
|
||
[d7b8d2d9-2d16-44c4-9a19-6e5f237cb71e] | ||
description = "returns the length of a list -> non-empty list" | ||
|
||
[c0bc8962-30e2-4bec-9ae4-668b8ecd75aa] | ||
description = "return a list of elements whose values equal the list value transformed by the mapping function -> empty list" | ||
|
||
[11e71a95-e78b-4909-b8e4-60cdcaec0e91] | ||
description = "return a list of elements whose values equal the list value transformed by the mapping function -> non-empty list" | ||
|
||
[613b20b7-1873-4070-a3a6-70ae5f50d7cc] | ||
description = "folds (reduces) the given list from the left with a function -> empty list" | ||
include = false | ||
|
||
[e56df3eb-9405-416a-b13a-aabb4c3b5194] | ||
description = "folds (reduces) the given list from the left with a function -> direction independent function applied to non-empty list" | ||
include = false | ||
|
||
[d2cf5644-aee1-4dfc-9b88-06896676fe27] | ||
description = "folds (reduces) the given list from the left with a function -> direction dependent function applied to non-empty list" | ||
include = false | ||
|
||
[36549237-f765-4a4c-bfd9-5d3a8f7b07d2] | ||
description = "folds (reduces) the given list from the left with a function -> empty list" | ||
reimplements = "613b20b7-1873-4070-a3a6-70ae5f50d7cc" | ||
|
||
[7a626a3c-03ec-42bc-9840-53f280e13067] | ||
description = "folds (reduces) the given list from the left with a function -> direction independent function applied to non-empty list" | ||
reimplements = "e56df3eb-9405-416a-b13a-aabb4c3b5194" | ||
|
||
[d7fcad99-e88e-40e1-a539-4c519681f390] | ||
description = "folds (reduces) the given list from the left with a function -> direction dependent function applied to non-empty list" | ||
reimplements = "d2cf5644-aee1-4dfc-9b88-06896676fe27" | ||
|
||
[aeb576b9-118e-4a57-a451-db49fac20fdc] | ||
description = "folds (reduces) the given list from the right with a function -> empty list" | ||
include = false | ||
|
||
[c4b64e58-313e-4c47-9c68-7764964efb8e] | ||
description = "folds (reduces) the given list from the right with a function -> direction independent function applied to non-empty list" | ||
include = false | ||
|
||
[be396a53-c074-4db3-8dd6-f7ed003cce7c] | ||
description = "folds (reduces) the given list from the right with a function -> direction dependent function applied to non-empty list" | ||
include = false | ||
|
||
[17214edb-20ba-42fc-bda8-000a5ab525b0] | ||
description = "folds (reduces) the given list from the right with a function -> empty list" | ||
reimplements = "aeb576b9-118e-4a57-a451-db49fac20fdc" | ||
|
||
[e1c64db7-9253-4a3d-a7c4-5273b9e2a1bd] | ||
description = "folds (reduces) the given list from the right with a function -> direction independent function applied to non-empty list" | ||
reimplements = "c4b64e58-313e-4c47-9c68-7764964efb8e" | ||
|
||
[8066003b-f2ff-437e-9103-66e6df474844] | ||
description = "folds (reduces) the given list from the right with a function -> direction dependent function applied to non-empty list" | ||
reimplements = "be396a53-c074-4db3-8dd6-f7ed003cce7c" | ||
|
||
[94231515-050e-4841-943d-d4488ab4ee30] | ||
description = "reverse the elements of the list -> empty list" | ||
|
||
[fcc03d1e-42e0-4712-b689-d54ad761f360] | ||
description = "reverse the elements of the list -> non-empty list" | ||
|
||
[40872990-b5b8-4cb8-9085-d91fc0d05d26] | ||
description = "reverse the elements of the list -> list of lists is not flattened" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{:aliases {:test {:extra-paths ["test"] | ||
:extra-deps {io.github.cognitect-labs/test-runner | ||
{:git/url "https://github.com/cognitect-labs/test-runner.git" | ||
:sha "705ad25bbf0228b1c38d0244a36001c2987d7337"}} | ||
:main-opts ["-m" "cognitect.test-runner"] | ||
:exec-fn cognitect.test-runner.api/test}}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
(defproject list-ops "0.1.0-SNAPSHOT" | ||
:description "list-ops exercise." | ||
:url "https://github.com/exercism/clojure/tree/main/exercises/list-ops" | ||
:dependencies [[org.clojure/clojure "1.10.0"]]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
(ns list-ops) | ||
|
||
(defn append | ||
"Given two vectors, it adds all the items in the second vector to the end of the first vector" | ||
[coll1 coll2] | ||
;; your code goes here | ||
) | ||
|
||
(defn concatenate | ||
"Given a vector of vectors, it combines all the vectors into one flattened vector" | ||
[colls] | ||
;; your code goes here | ||
) | ||
|
||
(defn select-if | ||
"Given a predicate and a vector, it returns the vector of all items for which predicate(item) is true" | ||
[pred coll] | ||
;; your code goes here | ||
) | ||
|
||
(defn length | ||
"Given a vector, it returns the number of items within it" | ||
[coll] | ||
;; your code goes here | ||
) | ||
|
||
(defn apply-to-each | ||
"Given a function and a vector, it returns the vector of the results of applying function(item) on all items" | ||
[f coll] | ||
;; your code goes here | ||
) | ||
|
||
(defn foldl | ||
"Given a function, a vector, and initial accumulator, it folds (reduces) each item into the accumulator from the left" | ||
[f coll init] | ||
;; your code goes here | ||
) | ||
|
||
(defn foldr | ||
"Given a function, a vector, and an initial accumulator, it folds (reduces) each item into the accumulator from the right" | ||
[f coll init] | ||
;; your code goes here | ||
) | ||
|
||
(defn reverse-order | ||
"Given a vector, it returns a vector with all the original items, but in reverse order" | ||
[coll] | ||
;; your code goes here | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
(ns list-ops-test | ||
(:require [clojure.test :refer [deftest testing is]] | ||
list-ops)) | ||
|
||
(deftest append-test | ||
(testing "empty vectors" | ||
(is (= [] (list-ops/append [] [])))) | ||
(testing "vector to empty vector" | ||
(is (= [1 2 3 4] (list-ops/append [] [1 2 3 4])))) | ||
(testing "empty vector to vector" | ||
(is (= [1 2 3 4] (list-ops/append [1 2 3 4] [])))) | ||
(testing "non-empty vectors" | ||
(is (= [1 2 2 3 4 5] (list-ops/append [1 2] [2 3 4 5]))))) | ||
|
||
(deftest concatenate-test | ||
(testing "empty vector" | ||
(is (= [] (list-ops/concatenate [])))) | ||
(testing "vector of vectors" | ||
(is (= [1 2 3 4 5 6] (list-ops/concatenate [[1 2] [3] [] [4 5 6]])))) | ||
(testing "vector of nested vectors" | ||
(is (= [[1] [2] [3] [] [4 5 6]] (list-ops/concatenate [[[1] [2]] [[3]] [[]] [[4 5 6]]]))))) | ||
|
||
(deftest select-if-test | ||
(testing "empty vector" | ||
(is (= [] (list-ops/select-if (fn [x] (= (mod x 2) 1)) []))) | ||
(testing "non-empty vector" | ||
(is (= [1 3 5] (list-ops/select-if (fn [x] (= (mod x 2) 1)) [1 2 3 5])))))) | ||
|
||
(deftest length-test | ||
(testing "empty vector" | ||
(is (= 0 (list-ops/length [])))) | ||
(testing "non-empty vector" | ||
(is (= 4 (list-ops/length [1 2 3 4]))))) | ||
|
||
(deftest apply-to-each-test | ||
(testing "empty vector" | ||
(is (= [] (list-ops/apply-to-each (fn [x] (+ x 1)) [])))) | ||
(testing "non-empty vector" | ||
(is (= [2 4 6 8] (list-ops/apply-to-each (fn [x] (+ x 1)) [1 3 5 7]))))) | ||
|
||
(deftest foldl-test | ||
(testing "empty vector" | ||
(is (= 2 (list-ops/foldl (fn [acc el] (* el acc)) [] 2)))) | ||
(testing "direction independent function applied to non-empty vector" | ||
(is (= 15 (list-ops/foldl (fn [acc el] (+ el acc)) [1 2 3 4] 5)))) | ||
(testing "direction dependent function applied to non-empty vector" | ||
(is (= 64 (list-ops/foldl (fn [acc el] (/ el acc)) [1 2 3 4] 24))))) | ||
|
||
(deftest foldr-test | ||
(testing "empty vector" | ||
(is (= 2 (list-ops/foldr (fn [acc el] (* el acc)) [] 2)))) | ||
(testing "direction independent function applied to non-empty vector" | ||
(is (= 15 (list-ops/foldr (fn [acc el] (+ el acc)) [1 2 3 4] 5)))) | ||
(testing "direction dependent function applied to non-empty vector" | ||
(is (= 9 (list-ops/foldr (fn [acc el] (/ el acc)) [1 2 3 4] 24))))) | ||
|
||
(deftest reverse-order-test | ||
(testing "empty vector" | ||
(is (= [] (list-ops/reverse-order [])))) | ||
(testing "non-empty vector" | ||
(is (= [7 5 3 1] (list-ops/reverse-order [1 3 5 7])))) | ||
(testing "vector of vectors is not flattened" | ||
(is (= [[4 5 6] [] [3] [1 2]] (list-ops/reverse-order [[1 2] [3] [] [4 5 6]]))))) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just delete this line because we implemented all operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbicodes The contents of this file comes from the problem specifications, which is also used by the other tracks. I think we would need to update it in the problem specification to remove it, but that could effect the instructions in the other tracks when they are re-synced.