Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: pin pydata sphinx theme and update regression tests #862

Merged
merged 13 commits into from
Oct 30, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 30, 2024

Our upstream theme has moved to sphinx>=6.1. Given our limited maintenance resources, we should mirror this to avoid testing two sets of pydata-sphinx-theme versions.

myst-parser also introduces changes to the AST that add to our maintenance burden. Rather than splitting our regression tests to handle a matrix of sphinx and parser versions, I'm going to drop myst-parser usage except for in the smallest of places.

@agoose77 agoose77 force-pushed the agoose77/fix-pin-pydata-sphinx-theme branch from 834ac48 to 933bfd8 Compare October 30, 2024 10:54
@agoose77 agoose77 force-pushed the agoose77/fix-pin-pydata-sphinx-theme branch from d3f68a5 to ef36307 Compare October 30, 2024 11:28
@agoose77
Copy link
Collaborator Author

@choldgraf I'm pinging you to let you know that I'm removing most usages of myst-parser in our test suite, to avoid things breaking that have nothing to do with this theme.

We still use myst-parser via myst-nb.

@agoose77 agoose77 merged commit 47ba32f into master Oct 30, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant