Skip to content

🔧 MAINTAIN: Update ReadTheDocs build #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 21, 2020
Merged

🔧 MAINTAIN: Update ReadTheDocs build #101

merged 5 commits into from
Dec 21, 2020

Conversation

chrisjsewell
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #101 (193bbb5) into master (c238306) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          69       69           
  Lines        2911     2911           
=======================================
  Hits         2809     2809           
  Misses        102      102           
Flag Coverage Δ
pytests 96.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c238306...193bbb5. Read the comment docs.

@hukkin
Copy link
Contributor

hukkin commented Dec 18, 2020

One idea comes to mind that could be useful if the new pip dependency resolver continues to use too many resources or be slow: Use Poetry for packaging and dependencies, and do poetry export to dump a resolved requirements.txt for RTD to pip install.

EDIT: Here's a quick read on why pip dependency resolver probably wil keep on being slow https://python-poetry.org/docs/faq/#why-is-the-dependency-resolution-process-slow 😢

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Dec 19, 2020

yeh I figured out the issue I think, that both jupytext, then myst-nb need updating to use the new version of markdown-it-py:

@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: Fix RTD build 🔧 MAINTAIN: Update myst-nb version Dec 21, 2020
@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: Update myst-nb version 🔧 MAINTAIN: Update ReadTheDocs versions Dec 21, 2020
@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: Update ReadTheDocs versions 🔧 MAINTAIN: Update ReadTheDocs build Dec 21, 2020
@chrisjsewell chrisjsewell merged commit a566e39 into master Dec 21, 2020
@chrisjsewell chrisjsewell deleted the fix-rtd branch December 21, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants