Added some comments and docstrings #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
reviewed
Dec 20, 2024
| @@ -13,6 +13,9 @@ class Dataset: | |||
|
|
|||
| The TableLike refers to a database table containing the actual data that | |||
| can be used for instance in training or testing. | |||
|
|
|||
| Q. A TableLike is basically a list of columns and a name. Why do we have | |||
| a separate list of columns here? | |||
There was a problem hiding this comment.
AFAIK there was and is a separation of "ordinary" columns and "identifier columns" which may be handled specially in some cases? But the attribute columns could be superfluous in my understanding.
There was a problem hiding this comment.
Yeah, that's what I meant. The identifier_columns OK, I can understand. But just columns are inside the table_like and then also separately. Why?
There was a problem hiding this comment.
I cannot answer your question. Could you ask @tkilias ?
I am happy to join a discussion so that I can understand the background.
ckunki
reviewed
Dec 20, 2024
ckunki
requested changes
Dec 20, 2024
exasol/analytics/query_handler/graph/stage/sql/execution/query_handler_state.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Kuhnke <[email protected]>
…_handler_state.py Co-authored-by: Christoph Kuhnke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.