This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
Added ssh_port parameter to override default one #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second parameter of params_lookup should be either undefined or 'global'. The default is set by setting the variable in the params class. Otherwise, I think it looks good ;) |
| @@ -25,6 +25,7 @@ | |||
| $log_forward = params_lookup( 'log_forward' ), | |||
| $log_level = params_lookup( 'log_level' ), | |||
| $safe_ssh = params_lookup( 'safe_ssh' ), | |||
| $ssh_port = params_lookup( 'ssh_port', '22' ), | |||
There was a problem hiding this comment.
The default value has to be placed in params.pp
Remove the 22 here and place $ssh_port = 22 somwhere in params.pp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a ssh_port parameter when using non standard ssh port. Default one stay port 22.