🚨 webauthn: fix android lint warnings

exactly · Jun 19, 2024 · 5187cfb · 5187cfb
1 parent 9fd6f71
commit 5187cfb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/app.config.ts b/app.config.ts
@@ -23,7 +23,12 @@ export default {
     [
       "expo-build-properties",
       {
-        android: { compileSdkVersion: 34, targetSdkVersion: 34, packagingOptions: { pickFirst: ["**/libcrypto.so"] } },
+        android: {
+          minSdkVersion: 28,
+          targetSdkVersion: 34,
+          compileSdkVersion: 34,
+          packagingOptions: { pickFirst: ["**/libcrypto.so"] },
+        },
         ios: { deploymentTarget: "13.4" },
       } as BuildPropertiesConfig,
     ],

diff --git a/webauthn/android/build.gradle b/webauthn/android/build.gradle
@@ -62,7 +62,7 @@ android {
 
   namespace "expo.modules.webauthn"
   defaultConfig {
-    minSdkVersion safeExtGet("minSdkVersion", 21)
+    minSdkVersion safeExtGet("minSdkVersion", 28)
     targetSdkVersion safeExtGet("targetSdkVersion", 34)
     versionCode 1
     versionName "0.1.0"

diff --git a/webauthn/android/src/main/java/expo/modules/webauthn/ExpoWebauthn.kt b/webauthn/android/src/main/java/expo/modules/webauthn/ExpoWebauthn.kt
@@ -11,6 +11,7 @@ import expo.modules.kotlin.functions.Coroutine
 import expo.modules.kotlin.modules.Module
 import expo.modules.kotlin.modules.ModuleDefinition
 
+@Suppress("unused")
 class ExpoWebauthn : Module() {
   override fun definition() = ModuleDefinition {
     Name("ExpoWebauthn")