✨ webauthn: serialize android response

exactly · Nov 14, 2023 · 3a97784 · 3a97784
1 parent 40f9c4e
commit 3a97784
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/webauthn/android/src/main/java/expo/modules/webauthn/ExpoWebauthn.kt b/webauthn/android/src/main/java/expo/modules/webauthn/ExpoWebauthn.kt
@@ -5,6 +5,7 @@ import androidx.credentials.CredentialManager
 import androidx.credentials.GetCredentialRequest
 import androidx.credentials.GetPasswordOption
 import androidx.credentials.GetPublicKeyCredentialOption
+import androidx.credentials.PublicKeyCredential
 import expo.modules.kotlin.exception.Exceptions
 import expo.modules.kotlin.functions.Coroutine
 import expo.modules.kotlin.modules.Module
@@ -22,10 +23,10 @@ class ExpoWebauthn : Module() {
 
     AsyncFunction("get") Coroutine { requestJSON: String ->
       val activity = appContext.currentActivity ?: throw Exceptions.MissingActivity()
-      CredentialManager.create(activity).getCredential(
+      (CredentialManager.create(activity).getCredential(
         activity,
         GetCredentialRequest(listOf(GetPublicKeyCredentialOption(requestJSON), GetPasswordOption()))
-      )
+      ).credential as PublicKeyCredential).authenticationResponseJson
     }
   }
 }
diff --git a/webauthn/src/index.ts b/webauthn/src/index.ts
@@ -1,16 +1,16 @@
-import { encode } from "base64-arraybuffer";
+import { encode, decode } from "base64-arraybuffer";
 
 import ExpoWebauthn from "./ExpoWebauthn";
 
 // @ts-expect-error -- polyfill
 global.navigator.credentials ??= {
-  get(options) {
+  async get(options) {
     if (!options?.publicKey) throw new Error("publicKey required");
-    return ExpoWebauthn.get(stringify(options.publicKey));
+    return parse(await ExpoWebauthn.get(stringify(options.publicKey)));
   },
   async create(options) {
     if (!options?.publicKey) throw new Error("publicKey required");
-    return ExpoWebauthn.create(stringify(options.publicKey));
+    return parse(await ExpoWebauthn.create(stringify(options.publicKey)));
   },
 } as CredentialsContainer;
 
@@ -22,3 +22,20 @@ function stringify(value: unknown) {
     return v as unknown;
   });
 }
+
+function parse(text: string) {
+  return JSON.parse(text, (key, v) => {
+    if (
+      typeof v === "string" &&
+      (key === "rawId" ||
+        key === "signature" ||
+        key === "userHandle" ||
+        key === "clientDataJSON" ||
+        key === "authenticatorData" ||
+        key === "clientExtensionResults")
+    ) {
+      return decode(v.replace(/-/g, "+").replace(/_/g, "/"));
+    }
+    return v as unknown;
+  }) as PublicKeyCredential;
+}