Инкремент №15 #15
Merged
Инкремент №15 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ex0rcist
commented
Aug 21, 2024
•
ex0rcist
commented
- Проверку входящей подписи и добавление исходящей подписи реализовал в middleware
- Опросом и отправкой у меня изначально занимались разные горутины, для реализации worker pool я разделил exporter на два вида - batch_exporter остался старый с прошлого спринта, а limited_exporter реализовал отдельными запросами на каждую метрику (как было до batch), кол-во воркеров определяется параметром -l (RATE_LIMIT)
tmvrus
approved these changes
Aug 25, 2024
Comment on lines
+194
to
+205
| exporterKind := detectExporterKind(config) | ||
|
|
||
| switch exporterKind { | ||
| case exporter.KindLimited: | ||
| exp = exporter.NewLimitedExporter(&config.Address, signer, config.RateLimit) | ||
| case exporter.KindBatch: | ||
| exp = exporter.NewBatchExporter(&config.Address, signer) | ||
| default: | ||
| exp, err = nil, fmt.Errorf("unknown exporter type") | ||
| } | ||
|
|
||
| return exp, err |
There was a problem hiding this comment.
detectExporterKind вызывается только тут, и частично, дублирует логику отсюда, я бы предложил переписать это более компактно:
if c.RateLimit > 0 {
return exporter.NewLimitedExporter(&config.Address, signer, config.RateLimit)
}
return exporter.NewBatchExporter(&config.Address, signer)
Выглядит так, что можно и без ошибки обойтись, так как она нужна только что бы поймать "невалидный" типа экспортера.
Comment on lines
+98
to
+102
| if e.err == nil { | ||
| return nil | ||
| } | ||
|
|
||
| return fmt.Errorf("metrics export failed: %w", e.err) |
There was a problem hiding this comment.
это кстати можно переписать в одно строку
return fmt.Errorf("metrics export failed: %w", e.err)
если e.err будет nil то Errorf ошибку не вернет
Comment on lines
+54
to
+65
| switch value.Kind() { | ||
| case metrics.KindCounter: | ||
| mex = metrics.NewUpdateCounterMex(name, value.(metrics.Counter)) | ||
|
|
||
| case metrics.KindGauge: | ||
| mex = metrics.NewUpdateGaugeMex(name, value.(metrics.Gauge)) | ||
|
|
||
| default: | ||
| logging.LogError(entities.ErrMetricReport, "unknown metric") | ||
|
|
||
| e.err = entities.ErrMetricUnknown | ||
| return e |
There was a problem hiding this comment.
рекомендую заменить на type switch, так будет безопаснее, если кто-то перепутает значения:
swith v := value.(type)
case metrics.Counter:
mex = metrics.NewUpdateCounterMex(name, v)
case metrics.Gauge
mex = metrics.NewUpdateGaugeMex(name, v)
// .... |
|
||
| url := "http://" + e.baseURL.String() + "/update" | ||
|
|
||
| req, err := http.NewRequest(http.MethodPost, url, payload) |
There was a problem hiding this comment.
есть http.NewRequestWithContext, лучше взять за правило всегда использовать запрос с контекстом
| return fmt.Errorf("cpu.PercentWithContext: %w", err) | ||
| } | ||
|
|
||
| s.CPUutilization = []metrics.Gauge{} |
There was a problem hiding this comment.
Размер []metrics.Gauge{} можно было указать заранее
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.