Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom parser as opts for invoke/4 #33

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

jokawachi-hg
Copy link
Contributor

No description provided.

@bernardd
Copy link
Contributor

Thanks @jokawachi-hg! Just as a request for next time, if you can run mix format over your PR before opening it, that saves me some time.

@bernardd bernardd merged commit b1d1a5d into ex-aws:main Sep 25, 2023
12 checks passed
@jokawachi-hg
Copy link
Contributor Author

Thanks @jokawachi-hg! Just as a request for next time, if you can run mix format over your PR before opening it, that saves me some time.

@bernardd I'm really sorry for the inconvenience! I had intended to open the PR for an internal review and should've caught the formatting. I really appreciate you taking a look so quickly!

@jokawachi-hg jokawachi-hg deleted the jo_allow_custom_parser_as_opts branch September 25, 2023 17:44
@bernardd
Copy link
Contributor

No drama :) You got lucky with the timing - I was like two months behind on PRs and just happened to pick yesterday to catch up :)

@jokawachi-hg
Copy link
Contributor Author

No drama :) You got lucky with the timing - I was like two months behind on PRs and just happened to pick yesterday to catch up :)

Sweet! Thanks again @bernardd! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants