Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AWS partition detection regex #880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liamwhite
Copy link
Contributor

There aren't any known AWS regions that have more than a single digit in the number (as far as I know). This regex fixes compatibility with Backblaze B2's region names, which are of the form us-west-000.

@bernardd
Copy link
Contributor

I've been thinking about this and I'm not sure I really like the idea of identifying Backblaze (or other providers) regions as AWS when they're really not. I think the right solution here would be list Backblaze as a separate partition in priv/endpoints, and have 3-digit region names point to it instead (ie, add another entry to the @partitions attribute). In the future this may result in us having overlapping regex partition identifiers, in which case we'll need to think about adding an optional provider config setting to allow it to choose, but for now, if all Backblaze partitions have 3 digits that should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants