Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to perform octet streaming #1012

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

avinayak
Copy link

@avinayak avinayak commented Nov 5, 2023

I am trying to Add support for S3 Select (https://docs.aws.amazon.com/AmazonS3/latest/userguide/selecting-content-from-objects.html) in ex_aws_s3.

However, the response of this request is an octet-stream and since this request does not support Range header, we cannot execute this request like how we do ExAws.S3.download_file.

This PR is related to changes in ex-aws/ex_aws_s3#236

@avinayak avinayak changed the title feat: EventStream for SelectObjectContentRequest feat: Add ability to perform octet streaming Nov 7, 2023
@avinayak avinayak marked this pull request as ready for review November 7, 2023 23:29
@avinayak
Copy link
Author

avinayak commented Nov 9, 2023

ping @bernardd

@bernardd
Copy link
Contributor

Hi @avinayak - sincere apologies for not getting to this sooner - it slipped through the cracks and I didn't get back to it. I will do my best to get to it this week. If I recall correctly, it failed some of the CI checks when they were run (but it's taken me so long to get back to it that the logs are now gone). If you're able to have a quick look at that that would be great.

@avinayak
Copy link
Author

Hi @avinayak - sincere apologies for not getting to this sooner - it slipped through the cracks and I didn't get back to it. I will do my best to get to it this week. If I recall correctly, it failed some of the CI checks when they were run (but it's taken me so long to get back to it that the logs are now gone). If you're able to have a quick look at that that would be great.

I'll fix the issues with this PR as soon as I can. Thanks for replying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants